Skip to content

Fix bad completion cache in call(new |) #12382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2025
Merged

Fix bad completion cache in call(new |) #12382

merged 2 commits into from
Nov 18, 2025
+1 −1

Conversation

@RblSb
Copy link
Member

@RblSb RblSb commented Oct 5, 2025

Closes vshaxe/vshaxe#668

in this call(new |) case after typing space we trigger display/completion request with completion list, but then display/signatureHelp request overwrites completion cache with this unexpected raise_fields:

Called from DisplayException.raise_fields in file "src/context/display/displayException.ml", line 17, characters 39-53
Called from Typeload.load_type_def in file "src/typing/typeload.ml", line 199, characters 2-110
Called from Typeload.load_instance' in file "src/typing/typeload.ml", line 406, characters 11-43
Called from Typeload.load_instance in file "src/typing/typeload.ml", line 440, characters 10-48
Called from TyperDisplay.handle_signature_display in file "src/typing/typerDisplay.ml", line 313, characters 45-104
Called from TyperDisplay.handle_display in file "src/typing/typerDisplay.ml", line 623, characters 2-37

It seems like in signature mode there should be no raise_fields? Let me know if i'm missing some logic there.

@skial skial mentioned this pull request Oct 29, 2025
Open
11 tasks
@RblSb RblSb force-pushed the random-new-completion branch from d73bdfa to d31d2ee Compare November 8, 2025 16:59
@kLabz
Copy link
Contributor

kLabz commented Nov 17, 2025

What I'm mostly concerned with, is what should happen in the t = Parser.magic_type_path case when ctx.com.display.dms_kind <> DMDefault 🤔

I'm not really familiar with that part :/

@Simn
Copy link
Member

Simn commented Nov 17, 2025

This magic type path business is specifically for cases where there isn't a path, so I don't think any display mode other than completion makes sense for it. Although this likely means that the parser shouldn't emit it in the first place...

@kLabz
Copy link
Contributor

kLabz commented Nov 17, 2025

Yeah it does sound weird.. and since I don't know about it, I'm not sure just ignoring it in such cases is really safe 🤔

@Simn Simn merged commit e489e4d into HaxeFoundation:development Nov 18, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Random completion after new

3 participants

@RblSb @kLabz @Simn